Can't disable Spell Overlay Glow (yellow border)

tullamods / Dominos

A main actionbar replacement

https://tullamods.com/dominos

BSD 3-Clause "New" or "Revised" License

79 stars 26 forks source link

Can't disable Spell Overlay Glow (yellow border) #876

Closed Aur0r4 closed 2 months ago

Aur0r4 commented 3 months ago

Hello,

I can't get rid of the Spell-Overlay-Glow even when I disable it in the Dominos configuration. I've disabled all other AddOns to test it, but as you can see on the screenshot, the glowing border effect is still showing.

Also the effect does not fade out after time, I have to mouse over it, to make it disappear.

Addon Version Dominos 11.0.0-retail

World of Warcraft Version Retail

Aur0r4 commented 3 months ago

As a workaround I'm using this now: https://www.curseforge.com/wow/addons/hideactionbaranimations

Tuller commented 3 months ago

Confirmed. The root cause is that Blizzard calls UpdateOverlayGlow from its main Update method, which happens irrespective of the events being registered. Dominos will need to hook that method, (or ActionButton_ShowOverlayGlow) and hide if the setting is enabled.

Aur0r4 commented 2 months ago

Thank you that you have fixed it so fast. This is working as expected now.

Closing ticket as it is resolved.