tullamods / Dominos

A main actionbar replacement
https://tullamods.com/dominos
BSD 3-Clause "New" or "Revised" License
79 stars 26 forks source link

Error on SOD Classic Era PTR - Keybinds don't save #882

Closed holypalaswe closed 2 months ago

holypalaswe commented 2 months ago

Addon Version 11.0.1-classic

World of Warcraft Version SOD Classic ERA PTR

Any changes to keybinds are not saved when I /reload or relog.

3 different lua errors: Lua error on login:

[string "=[C]"]: in function `CreateFrame'
[string "@Dominos/libs/LibKeyBound-1.0-100003/LibKeyBound-1.0.lua"]:95: in function `Initialize'
[string "@Dominos/libs/LibKeyBound-1.0-100003/LibKeyBound-1.0.lua"]:671: in function <...Ons/Dominos/libs/LibKeyBound-1.0/LibKeyBound-1.0.lua:665>

Locals:
(*temporary) = "CheckButton"
(*temporary) = "KeyboundDialogCheck"
(*temporary) = KeyboundDialog {
 Center = Texture {
 }
 RightEdge = Texture {
 }
 backdropInfo = <table> {
 }
 BottomEdge = Texture {
 }
 BottomLeftCorner = Texture {
 }
 BottomRightCorner = Texture {
 }
 TopEdge = Texture {
 }
 TopRightCorner = Texture {
 }
 TopLeftCorner = Texture {
 }
 LeftEdge = Texture {
 }
}
(*temporary) = "OptionsCheckButtonTemplate"

When opening dominos Bind Keys...

[string "@Dominos/libs/LibKeyBound-1.0-100003/LibKeyBound-1.0.lua"]:282: in function `Activate'
[string "@Dominos/Dominos.lua"]:485: in function `SetBindingMode'
[string "@Dominos/Dominos.lua"]:496: in function `ToggleBindingMode'
[string "@Dominos_Config/options/general.lua"]:35: in function <Dominos_Config/options/general.lua:34>
[string "=[C]"]: ?
[string "@Dominos_Config/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:45: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:43>
[string "@Dominos_Config/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:839: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:661>
[string "=[C]"]: ?
[string "@Dominos_Config/libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <Dominos_Config/libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@Dominos_Config/libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@Dominos_Config/libs/AceGUI-3.0-41/widgets/AceGUIWidget-Button.lua"]:22: in function <...nfig/libs/AceGUI-3.0/widgets/AceGUIWidget-Button.lua:19>

Locals:
self = <table> {
 EventButton = Frame {
 }
 L = <table> {
 }
 enabled = true
 events = <table> {
 }
 frame = Button {
 }
 colorKeyBoundMode = <table> {
 }
 Binder = <table> {
 }
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = Button {
 text = OVERLAY {
 }
}
(*temporary) = Button {
 text = OVERLAY {
 }
}
(*temporary) = nil
(*temporary) = "attempt to index field 'dialog' (a nil value)"
L = <table> {
 Alt = "A"
 Button19 = "B19"
 BindingsHelp = "Hover over a button, then press a key to set its binding.  To clear a button's current keybinding, press %s."
 Backspace = "BS"
 End = "En"
 BASEREVISION = 90119
 CombatBindingsEnabled = "Exiting combat, keybinding mode enabled"
 Button17 = "B17"
 Page Up = "PU"
 CannotBindInCombat = "Cannot bind keys in combat"
 Capslock = "Cp"
 REVISION = 0
 Down Arrow = "Dn"
 Button9 = "B9"
 Disabled = "Bindings mode disabled"
 ClearedBindings = "Removed all bindings from %s"
 NoKeysBoundTip = "No current bindings"
 UnboundKey = "Unbound %s from %s"
 Button25 = "B25"
 Button28 = "B28"
 Button26 = "B26"
 Insert = "Ins"
 Button21 = "B21"
 Page Down = "PD"
 Button30 = "B30"
 Right Arrow = "Rt"
 BindingMode = "Binding Mode"
 Button3 = "B3"
 BoundKey = "Set %s to %s"
 Button20 = "B20"
 ClearTip = "Press Escape to clear all bindings"
 Scroll Lock = "SL"
 Button10 = "B10"
 Button2 = "B2"
 Button24 = "B24"
 Button1 = "B1"
 Button22 = "B22"
 NumPad = "N"
 Ctrl = "C"
 Button7 = "B7"
 Button23 = "B23"
 Up Arrow = "Up"
 Left Arrow = "Lf"
 Tab = "Tb"
 Button16 = "B16"
 Button8 = "B8"
 Button14 = "B14"
 Button29 = "B29"
 Spacebar = "Sp"
 Shift = "S"
 Num Lock = "NL"
 Button4 = "B4"
 Button18 = "B18"
 Enabled = "Bindings mode enabled"
 Mouse Wheel Up = "WU"
 Mouse Wheel Down = "WD"
 Home = "HM"
 Delete = "Del"
 Clear = "Cl"
 Button31 = "B31"
 Command = "M"
 Button15 = "B15"
 Button5 = "B5"
 Button12 = "B12"
 Button11 = "B11"
 CombatBindingsDisabled = "Entering combat, keybinding mode disabled"
 Button6 = "B6"
 Button13 = "B13"
 Button27 = "B27"
}
LibKeyBound = <table> {
 EventButton = Frame {
 }
 L = <table> {
 }
 enabled = true
 events = <table> {
 }
 frame = Button {
 }
 colorKeyBoundMode = <table> {
 }
 Binder = <table> {
 }
}

When closing dominos Bind Keys...

[string "@Dominos/libs/LibKeyBound-1.0-100003/LibKeyBound-1.0.lua"]:301: in function `Deactivate'
[string "@Dominos/Dominos.lua"]:487: in function `SetBindingMode'
[string "@Dominos/Dominos.lua"]:496: in function `ToggleBindingMode'
[string "@Dominos_Config/options/general.lua"]:35: in function <Dominos_Config/options/general.lua:34>
[string "=[C]"]: ?
[string "@Dominos_Config/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:45: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:43>
[string "@Dominos_Config/libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:839: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:661>
[string "=[C]"]: ?
[string "@Dominos_Config/libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <Dominos_Config/libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@Dominos_Config/libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@Dominos_Config/libs/AceGUI-3.0-41/widgets/AceGUIWidget-Button.lua"]:22: in function <...nfig/libs/AceGUI-3.0/widgets/AceGUIWidget-Button.lua:19>

Locals:
self = <table> {
 EventButton = Frame {
 }
 L = <table> {
 }
 events = <table> {
 }
 frame = Button {
 }
 colorKeyBoundMode = <table> {
 }
 Binder = <table> {
 }
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'dialog' (a nil value)"
Tuller commented 2 months ago

This one is actually a bug in LibKeyBound. I've reported it here: https://www.wowace.com/projects/libkeybound-1-0/issues/12

Raina1007 commented 2 months ago

@Tuller Just a heads up, this also happened on Cata PTR, but your solution in the issue fixed it.

Tuller commented 2 months ago

Worst case, I'll fork the library.

Tuller commented 2 months ago

LibKeyBound has been updated. The latest beta release of Dominos includes the fix.

Raina1007 commented 2 months ago

Got the update and tested on cata ptr, everything is working how it should :-) No lua errors