search

tullamods / OmniCC

Cooldown count for everything
https://tullamods.com/omnicc
MIT License
99 stars 21 forks source link

Big CDs wrong CD showing #277

Closed 333silas closed 5 years ago

333silas commented 6 years ago

So i started useing an addon called Gladiusex with OmniCC to Show cd , it works perfectly fine for all abilitys but stuff like Divine Shield , Bop ( Blessing of Protection) , Life swap from Priest Show wrong cooldown timers ( basically all abilities with high cd )

Does this have to do with Gldaiusex or sth with Omnicc

Tuller commented 6 years ago

Do you have screenshots?

ChadCloman commented 5 years ago

I am seeing this issue and do NOT have Gladiusex installed. The displayed time dropped to 2 hours after the actual time dropped below 1.5 hours, so I think it may be doubling the time somehow. Here's a screen print:

omnicc - wrong time

ChadCloman commented 5 years ago

Some more information. I have several long cooldowns and am seeing the following:

1h24m showing as 2h 3h47m showing as 5h 7h57m showing as 9h

So it's not a doubling; rather, it appears to be adding an hour. Probably an off-by-one error somewhere.

ChadCloman commented 5 years ago

I found the error. In core/timer.lua, there is the following line, which is supposed to be the number of ms in a half hour: local HALF_HOUR = 5400000 This is actually the value for 90 minutes. The correct value is: local HALF_HOUR = 1800000

Tuller commented 5 years ago

That would definitely cause issues :p