search

tullamods / OmniCC

Cooldown count for everything
https://tullamods.com/omnicc
MIT License
99 stars 21 forks source link

Not working good with NamePlateKAI #282

Closed JatlinWang closed 5 years ago

JatlinWang commented 6 years ago

OmniCC 8.0.9 NamePlateKAI 8.0.74 Assassination Rogue debuff duration text always missing. please fix it.

screen shot 2018-11-15 at 7 54 28 pm
Tuller commented 6 years ago

The reason this one doesn't work for OmniCC is a bit complicated. To explain, this is what OmniCC looks like for a typical cooldown: image That is, there's an ability (action, buff, spell) with a cooldown object (the spiral), and OmniCC's cooldown text. The ability frame contains the icon, and there's a cooldown spiral + omnicc's text display as children.

In the case of an action button, it looks more like this: image That is, there's the potential of multiple cooldown spirals for a single ability. In order to not display multiple cooldown texts, OmniCC picks the most relevant one and parks its text display over the cooldown it picked.

Now for the case of NamePlateKAI: image The icon for a cooldown is intermingled with the spiral, and all cooldowns on a nameplate share a common parent. OmniCC is again only showing text for one of those cooldowns, in this case the one with the shortest duration remaining.

I don't really have a fix for this one at the moment.

JatlinWang commented 6 years ago

very clear explanation.

JatlinWang commented 6 years ago

Temporary solution for me： disable some codes in omnicc and nameplateKAI to prevent cvar countdownForCooldowns changed. change settings let nameplateKAI use biz default cooldown count. change settings let omnicc disable cooldown count for default group. use omnicc only for TWM and TargetFrameDebuff...

Looking forward to the new version of OmniCC. wechatimg9219