tullamods / tullaCC

Minimal addon for displaying cooldown text on buttons
MIT License
6 stars 1 forks source link

Hovering over a button that's on cooldown removes the timer from it #11

Closed johnsolver closed 7 years ago

johnsolver commented 7 years ago

Not sure if this is still 'supported' but since 7.1 if you hover over a button that's on CD the timer gets removed.

Tuller commented 7 years ago

Will try and reproduce. tullaCC/range should be updated by the end of the week, I just happened to be very busy this time around. On Fri, Oct 28, 2016 at 12:11 AM johnsolver notifications@github.com wrote:

Not sure if this is still 'supported' but since 7.1 if you hover over a button that's on CD the timer gets removed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tullamods/tullaCC/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/AALrB7_0QVRljbZgQU5yp-tblbTdkgmjks5q4XXVgaJpZM4KjD69 .

Tuller commented 7 years ago

This should be fixed with the latest release.

johnsolver commented 7 years ago

Yes it is, and so is the shadow on charges, thanks.

However it seems that something is still causing the timer to disappear sometimes (? not sure how, but it does in combat) I assume it's related to 'enable == 1' in the condition since after removing it, it works consistently.

Tuller commented 7 years ago

Removing the enable check was indeed the fix. Turns out, it isn't passed for everything.