search

tullamods / tullaRange

Colors actionbuttons when out of range
https://tullamods.com/tullaRange
MIT License
18 stars 6 forks source link

desaturated icons only on the "out of range" part of the addon #13

Closed dnlpz closed 1 year ago

dnlpz commented 1 year ago

Since yesterday, out of range abilities gets desaturated. Been with this addon, and its updates, since years. Never happened. tullabug

Guema commented 1 year ago

You are right, while i like this aspect, i understand some people may not enjoy it in those kind of situations I was thinking about some checkbox allowing to desaturate or not in each situation based on user choice

@Tuller is it something you would accept as PR ? (i'm ok to work on it myself as if we agree on the principle, i'll try to mimic the "default config" behviour, and by default it will be on for "oom" and "oor" but not on "disabled")

dnlpz commented 1 year ago

What I am referring to is that I have been with Tullarange for years and desaturation never happened until yesterday.

Tuller commented 1 year ago

Yes, working on a PR for this would be fine.

Tuller commented 1 year ago

What I am referring to is that I have been with Tullarange for years and desaturation never happened until yesterday.

Are you running the latest version? I did adjust it to not affect unusable yesterday

dnlpz commented 1 year ago

Are you running the latest version? I did adjust it to not affect unusable yesterday

Yeah. it all started yesterday with latest version. Unusable and no mana doesnt get desaturated. Only out of range.

dnlpz commented 1 year ago

If its intended wouldnt be ideal to put an option to desature or not desature? I dont dislike desaturation btw.

Thank you for the great work.

Guema commented 1 year ago

It is intentional.

I made a test because i had some of my spells rendering like nearly full black square.

Then i proposed it as pr. Here is an explanation of why : #12