tullamods / tullaRange

Colors actionbuttons when out of range
https://tullamods.com/tullaRange
MIT License
18 stars 6 forks source link

Latest Retail version shows spells as usable, incorrectly. (10.1.6) #32

Closed arcadepro closed 2 months ago

arcadepro commented 1 year ago

Current version (10.1.5/6 Retail) is little buggy. It causes spells on your bar to light up/desaturate incorrectly.

Skullsplitter (warrior) is fully lit when its on your bar but untalented. Execute (warrior) also is commonly fully saturated when unusable. Hovering over an incorrectly saturated Execute button causes it to update and fix its status temporarily.

This occurs whether the the Tullarange desaturate option is being used or not. So something is causing buttons to go full saturation incorrectly. Removing TullaRange causes execute (and other abilities) to function correctly.

Either it's the new event or the logic is a little wonky somewhere.

10.1.0 functions correctly.

rakkarage commented 1 year ago

Same problem.

WoWScrnShot_072623_113802 Execute is not usable here. But looks like it is.

I tested with no addons and works fine. Enabled only tullaRange and problem is back.

A slight workaround it to make a wa glow the button when really ready.

Thanks.

rakkarage commented 1 year ago

testing with execute as spell instead of macro (happens with both but maybe bit different)

in actionButton_UpdateColor execute seems to normally return usable=false oom=false oor=false when i charge changes to usable=false oom=false oor=true when i mouse over changes back to usable=false oom=false oor=false so seems like should not show as usable? but does? idk

i guess actionButton_UpdateColor needs to be called again or more often? idk adding hook to Update or OnUpdate as well seems to fix it soon after charge?

hooksecurefunc(button, "UpdateUsable", actionButton_UpdateUsable)
hooksecurefunc(button, "Update", actionButton_UpdateUsable)
hooksecurefunc(button, "OnUpdate", actionButton_UpdateUsable)

thanks

Tuller commented 1 year ago

Blizzard is making some updates to usability changes in 10.2 so that it becomes more event based like range checking is now. I’m waiting to see if that resolves any of the issues

arcadepro commented 3 months ago

This is still broken on pre-patch 11.0. Warrior execute being the prime suspect.

As referenced above, out of combat the button is greyed out. Charge into combat, the button lights up (when it should not unless target is in execute range). Hovering over the button causes it to grey out. Whatever is controlling the usable aspect is not working on this.

It can also be seen in Exiles Reach, the starter zone.

I wonder if the inconsistency depends on whether execute was, or was not, used in the previous 'in combat' encounter.