Closed merijn closed 3 years ago
Do you have an example macro?
(Side note: All of this refers to classic, I have no clue about the situation in retail)
I have several on my warrior, where I change to berserker stance and intercept in combat, or change to battle stance and charge if not. Something like:
#showtooltip [@mouseover,combat,harm,nodead][combat]Intercept;[harm,nodead][@mouseover,harm,nodead][]Charge
/target [nocombat,harm,nodead];[@mouseover,harm,nodead] mouseover;
/startattack
/use [combat]Berserker Stance
/use [form:3]Intercept;Charge
This doesn't show the stance change, only the skill after stance changing. This works because stance changes only trigger a cooldown on other stances, and not the global cooldown. Unfortunately, the macro highlight is always "unusable", because you are in the wrong stance.
A similar issue occurs for druids when you use /cancelform
to switch out of cat/bear/travel form and immediately cast a spell. The spells are always unusable, because you're in the wrong form.
With this changes, the "unusable" status is ignored and only range/cost are checked (manually, because IsUsableAction
only checks the mana cost if the ability is usable). I made it opt-in (i.e. checking the macro name) because not taking the usability into account isn't always the right thing to do, so I figured it'd be best to only do when explicitly wanted.
Quick and dirty prototype for the things I described in #6. Shouldn't have a meaningful performance impact, since most of the logic is limited to buttons that are 1) macros and 2) use the special opt-in name
#
(which should probably be configurable)