search

tulleuchen / jirastopwatch

Not MORE timetracking - just EASIER timetracking
http://jirastopwatch.com
Apache License 2.0
143 stars 99 forks source link

Bug in 1.9 beta: Exception first time I try to log time #49

Closed slarti-b closed 7 years ago

slarti-b commented 7 years ago

Running with 1.9 beta (6bbe5c4aa5ed478ac7e968d7ae411d54b9c05705) i have had a few occassions where I thought I had submitted but it was still there, this time Visual Studio came up with an exception. null reference in IssueControl.cs::UpdateRemainingEstimate at () => RemainingEstimate = timetracking.RemainingEstimate Continuing the app was there with the time still saved, clicking submit again worked fine.

This is connected to control of remaining stuff I did, so I'll try and have look this evening if I get time (or at the weekend otherwise) unless you find the answer first :)

carstengehling commented 7 years ago

Would you be able to send me the stacktrace?

carstengehling commented 7 years ago

I think I can guess why:

`` timetracking = jiraClient.GetIssueTimetracking(key);

GetIssueTimetracking() can return null if - for some reason - your call to the Jira API fails. so you should do a check for that before continuing. I'll add this.

slarti-b commented 7 years ago

OK! I have been away from the computer all weekend. Just put it on to look actually, was halfway through a comment on another issue.

Will try and repeat and confirm

From: Carsten Gehling [mailto:notifications@github.com] Sent: Sunday, January 22, 2017 22:39 To: carstengehling/jirastopwatch jirastopwatch@noreply.github.com Cc: Adam Conway Adam.Conway@carus.com; Author author@noreply.github.com Subject: Re: [carstengehling/jirastopwatch] Bug in 1.9 beta: Exception first time I try to log time (#49)

I think I can guess why:

`` timetracking = jiraClient.GetIssueTimetracking(key);

GetIssueTimetracking() can return null if - for some reason - your call to the Jira API fails. so you should do a check for that before continuing. I'll add this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/carstengehling/jirastopwatch/issues/49#issuecomment-274357546, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMXy-qGtR3RZBMFbWCcE6syXTZszrMh6ks5rU750gaJpZM4LoJkM.

carstengehling commented 7 years ago

FYI: I finally released version 1.9.0 :-)

slarti-b commented 7 years ago

Nice! Except that it crashes for me! Have created a new issue at https://github.com/carstengehling/jirastopwatch/issues/50 since it’s not connected to this (and this is closed)

Adam