search

tullinge / booking

🎫 Bokningssystem för allaktivitetsdag
MIT License
0 stars 1 forks source link

Dockerize flask #19

Closed einarpersson closed 4 years ago

einarpersson commented 4 years ago

This PR adds a Dockerfile for the flask app. The container runs the entrypoint.sh on startup which first waits for the databases to be ready, then runs database scripts and finally starts the app.

The database-scripts currently seeds dummy data, which should be removed. We could add proper migrations instead of just a single setup function but this should not be a priority right now.

I got rid of the db_config.py. Developer defaults are not sensitive and could just as well be in code, and the actual passwords etc is provided as environment variables when needed.

Fixes #12.

einarpersson commented 4 years ago

Thanks for your feedback.

So I'm thinking that docker-compose probably is enough for orchestration in this case. It should be fine for prototypes and simpler projects such as this. We can use several .yml-files like this.

docker-compose.yml docker-compose.prod.yml

Kubernetes is awesome but also feels a bit like overkill right now. There are so many new concepts... pods, autoscaler, resources, ingress, etc...