Fix importing of feeds where null instance references can contain spaces

tulsawebdevs / django-multi-gtfs

Django app to import and export General Transit Feed Specification (GTFS)

http://tulsawebdevs.org/

Apache License 2.0

50 stars 32 forks source link

Fix importing of feeds where null instance references can contain spaces #36

Closed juyrjola closed 9 years ago

juyrjola commented 9 years ago

The Helsinki Region Transport GTFS feed sometimes refers to parentless stops with a space (" ") in the parent_station field. Work around that problem by stripping the value before checking for the empty condition.

jwhitlock commented 9 years ago

Good fix. Can you make two changes:

Add "Copyright 2014 your name" to the top of multigtfs/models/base.py
Add your name and email to AUTHORS.rst

Apache 2 is a demanding license, but I'm hoping to integrate Google's validation code someday, and it's Apache 2.

juyrjola commented 9 years ago

Thanks for the feedback! I added a commit with the requested changes.

jwhitlock commented 9 years ago

I've fixed setup.py (wasn't importing non-ASCII rst files), added a test, and merged into the develop branch. I'll publish in the master branch with the 0.4.2 update in the next few days.