strip values from feeds so whitespace isn't stored and whitespace str…

tulsawebdevs / django-multi-gtfs

Django app to import and export General Transit Feed Specification (GTFS)

http://tulsawebdevs.org/

Apache License 2.0

50 stars 32 forks source link

strip values from feeds so whitespace isn't stored and whitespace str… #56

Closed davekaro closed 6 years ago

davekaro commented 7 years ago

…ings are treated as null

the sfmta transit data has rows like , , , that are parsed to strings like ' ' during import

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 2bef5eb3a8be88628541700b4cf29afc235ec367 on davekaro:import-compat into 988b4546e5a54d5974c8df6a767ad2647920d68e on tulsawebdevs:master.

jwhitlock commented 7 years ago

The SFMTA Data appears unavailable, because it links to a server https://gtfs.sfmta.com that can't be found. Do you have another source for this data?

This looks decent. It breaks the "input == output" rule, but I think it's a good change. I'd like a test that would fail before the strip() was added. Can you add that, or do you need help?

davekaro commented 7 years ago

Woah weird - I had been fetching the data from https://transitfeeds.com/p/sfmta/60 which does point at https://gtfs.sfmta.com/ for the official feed, which is down for me as well. Not sure what is going on there. Ok I'll add some tests when I can - thanks!