Send notification to Telegram devel group after build on master is finished

tulul / tululbot

Telegram Bot for Tululness

Apache License 2.0

8 stars 6 forks source link

Send notification to Telegram devel group after build on master is finished #46

Closed kmkurn closed 8 years ago

kmkurn commented 8 years ago

See #21

wazaundtechnik commented 8 years ago

The idea of notify in manage.py is somewhat unstructured. I think it shouldn't be in manage.py. manage.py is intended for development/testing-related function (like Makefile or rake).

But well, it is my opinion. Overall it is LGTM. If there is no additional concern from @fushar, it should be okay.

kmkurn commented 8 years ago

I kinda agree with you. It feels weird to put it under manage.py but at the same time, it doesn't feel worthwhile to have another Python file to store only this one command. This command is easy to refactor anyway so I decided to put it there.