refactor: DRY version - Githubissues

tulul / tululbot

Telegram Bot for Tululness

Apache License 2.0

8 stars 6 forks source link

refactor: DRY version #75

Open wazaundtechnik opened 7 years ago

wazaundtechnik commented 7 years ago

Do not hard code version into commands. Put it into separate file and let another module calls that command to retrieve version information.

coveralls commented 7 years ago

Coverage increased (+1.1%) to 93.493% when pulling accbf7eefabce7e8b44a447c44fce948b6aa7eb2 on wazaundtechnik:feature/standalone-version into 4b8f011602227f281eb494f83f1067e8885e13a0 on tulul:master.

coveralls commented 7 years ago

Coverage increased (+1.1%) to 93.493% when pulling 472dd13e65c65d3a2d2f8f36a1905fface064b7b on wazaundtechnik:feature/standalone-version into 4b8f011602227f281eb494f83f1067e8885e13a0 on tulul:master.

wazaundtechnik commented 7 years ago

Hey team i tried to change to what @kmkurn suggest, but the build was failed https://travis-ci.org/tulul/tululbot/builds/256555060. Can somebody help me and point out where is the mistake?

Previous build worked (when use standalone VERSION file).

kmkurn commented 7 years ago

@wazaundtechnik Sorry I think that's probably because of circular import or sth. I'm not sure either because I don't check myself. What if you put VERSION under tululbot/constants.py file, for instance?