Closed rafzi closed 9 months ago
The CI issue is a bit puzzling. It complains about:
D:\a\etiss\etiss\src\IntegratedLibrary\errorInjection\Plugin.cpp(155,31): error C2589: 'constant': illegal token on right side of '::' [D:\a\etiss\build\ETISS.vcxproj]
Which refers to:
It seems related to the issue that some Windows headers define this macro. However, everytime these return codes are referenced, they should include this header which is supposed to take care of that:
This PR doesn't touch any of those files or files that they include.
Performance Statistics
Status for the gcc Just-In-Time Engine (for commit 52d835ad): No significant performance change Current dhrystone MIPS for gcc JIT : 91.76 Previous best for gcc JIT (recorded in commit 4d2d26fb): 108.31, difference -15.27%
Status for the llvm Just-In-Time Engine (for commit 52d835ad): Regressed since commit 78716e7f Current dhrystone MIPS for llvm JIT : 24.89 Previous best for llvm JIT (recorded in commit 940dbdd7): 36.11, difference -31.07%
Status for the tcc Just-In-Time Engine (for commit 52d835ad): No significant performance change Current dhrystone MIPS for tcc JIT : 58.54 Previous best for tcc JIT (recorded in commit 40c0b920): 62.38, difference -6.14%
This comment was created automatically, please do not change!
@rafzi Do you know if there are any problems which need to be resolved before this can be merged?
@PhilippvK no, this is ready to merge
SelectiveSysWrapper: Only wraps some of the System calls to avoid unnecessary intermediate calls.
MemMappedPeriph: Currently unused, but useful as a base for lightweight memory mapped peripherals.
The Logger plugin was changed to use the SelectiveSysWrapper, so that it only has to override the dwrite System call. This improves performance by about 10% while the Logger is active.