Closed JoGei closed 2 months ago
Do you think this is a suitable solution? https://github.com/tum-ei-eda/etiss/pull/138/commits/0b8ad8ad0158062950a813b8b1485b77b1894e93 Removing all example parts? Or should the CI file load the submodule?
The etiss riscv tests moved to https://github.com/tum-ei-eda/etiss_riscv_examples.
(@wysiwyng)
To fix the CI in the etiss
repo we could:
etiss_riscv_examples
.
a) Using a submodule
b) Using checkout action in CIetiss_riscv_examples
repository and trigger it from the etiss
repo (if feasible)Do you think this is a suitable solution? 0b8ad8a Removing all example parts? Or should the CI file load the submodule?
No, not really. I think the examples and the CI tests were quite helpful as a form of "sanity tests". So I would try to keep them.
The etiss riscv tests moved to https://github.com/tum-ei-eda/etiss_riscv_examples.
(@wysiwyng)
To fix the CI in the
etiss
repo we could:1. Drop the CI jobs all together (not recommended) 2. Build new CI jobs in this repository based on `etiss_riscv_examples`. a) Using a submodule b) Using checkout action in CI 3. Add CI to `etiss_riscv_examples` repository and trigger it from the `etiss` repo (if feasible)
2.b) sounds best IMO
I also think 2.b) is the best option, I will rewrite the ci file. We could also add https://github.com/tum-ei-eda/etiss_riscv_tests here to have actual functional tests. These should then only report the status, not fail the CI when tests don't pass.
After commit 8f2fb89 removed the
examples/
CI was not updated and fails.