search

tum-ei-eda / etiss

Extendable Translating Instruction Set Simulator
https://tum-ei-eda.github.io/etiss/
Other
29 stars 36 forks source link

InstructionDefinition with missing callback causes FATALERROR #58

Closed wysiwyng closed 3 years ago

wysiwyng commented 3 years ago

Title. The error message which is printed in Instruction.h suggests that InstructionDefinitions with missing callbacks will be ignored, but not the termination of ETISS. What is the desired behavior here?

rafzi commented 3 years ago

Do they always have a callback in our current definitions?

If there is a use-case where it makes sense that they don't have one, it should be fine to allow this. Of course would have to be tested if everything else can deal with that case.

I don't know the historical reason why this was treated as fatal.

wysiwyng commented 3 years ago

Our current definitions always have a callback, this question arose from testing things for issue #59. Here I wanted to create minimal examples to keep clutter minimal, but ran into the problem that ETISS does not accept missing callbacks despite the error message stating otherwise.

It probably doesn't make much sense to allow missing callbacks other than for testing, I would just update the error message to reflect that.