tum-ei-eda / muriscv-nn

muRISCV-NN is a collection of efficient deep learning kernels for embedded platforms and microcontrollers.
Apache License 2.0
58 stars 6 forks source link

Fix broken compatibility with upstream TFLM #22

Closed PhilippvK closed 7 months ago

PhilippvK commented 1 year ago

This week the TFLM integration test broke due to upstream changes. (https://github.com/tum-ei-eda/muriscv-nn/actions/runs/4311825732)

TODO:

The fixed commit should be (automatically) updated to the latest commit which is known to be compatible.

PhilippvK commented 1 year ago

Follow-Up:

Find a way to store the last working TFLM commit somewhere in the repo (either a branch, wiki page or artifact) and update it unless the upstream TFLM integration failed. This wait we should always known which upstream commit is responsible for a failing test and cann still see if something breaks on our side while fixing the compatibily with upstream TLFM.

PhilippvK commented 1 year ago

Documenting the TFLM commit would also resolve the issues raised here: #17

PhilippvK commented 1 year ago

Seems like integration with TFLM broke again due to upstream changes. See: https://github.com/tum-ei-eda/muriscv-nn/actions/runs/5560759619

christian-herber-nxp commented 7 months ago

Could you specify the commit that the patch can be applied against currently?

PhilippvK commented 7 months ago

We actually support the latest version of TFLM on one of our development branches: https://github.com/tum-ei-eda/muriscv-nn/tree/test-sync

If the test-sync branch does not work for you, please reach out to us again.

We are currently working on a way to sync upstream CMSIS-NN changes automatically and will try merge these changes to the master branch ASAP. Sorry for the inconvenience.

christian-herber-nxp commented 7 months ago

the branch works for me