tum-esm / hermes

https://tenta-on-acropolis.fly.dev/

GNU Affero General Public License v3.0

9 stars 0 forks source link

Feature/code cleanup #169

Closed larsfroelich closed 7 months ago

larsfroelich commented 7 months ago

fixed spelling mistakes
re-organized module imports
removed unused imports
simplified code where possible
removed unused symbols/variables
improved compliance with PEP8

WARNING

This also includes fixing spelling mistakes in the config file, namely last_maintenance_date and maintenance_comment - this is also why CI tasks fail - as the config needs to be fixed first. When deploying to the cluster, this should not be an issue though, as updates to the cluster are done by sending a new config file, so the new config can contain the corrected fields as well, and integration tests won't fail.

larsfroelich commented 7 months ago

@patrickjaigner this is ready for merge now. Just keep in mind: the spelling mistakes in the fields "last_maintenance_date" and "maintenance_comment" in the config file have been fixed, so when this version of the code is deployed to the sensor cluster, that part of the config needs to be changed as well to prevent CI-tests from failing on the sensor nodes.