glob() finds gml-files twice

tum-gis / CityGML2OBJv2

Command line converter of CityGML (.gml) to OBJ (.obj) files, while maintaining the semantics

MIT License

31 stars 3 forks source link

glob() finds gml-files twice #4

Closed felix-mu closed 8 months ago

felix-mu commented 9 months ago

On my Windows machine with Python 3.10 I found that gml-files of the input directory are processed twice since the glob() function does not appear to be case in-sensitive and identifies identical gml-files twice when checking first on "*.gml" and then on "*.GML": https://github.com/tum-gis/CityGML2OBJv2/blob/c55356ab74606e9802ffa390bed7ac1953596c79/CityGML2OBJs.py#L348-L351

ThomasFroech commented 9 months ago

Hi, thank you for pointing this out. If my understanding is correct, modifying the types would solve the issue. Would you agree?

felix-mu commented 9 months ago

Yes you are right. My quick fix was to simply remove the upper case types. But did not test it with upper case file extensions so far

ThomasFroech commented 9 months ago

I have tested it and have not encountered any issues related to this change so far. I think that it solves the issue and I am therefore going to incorporate your approach. Thank you very much for your help!