search

tum-pbs / ConFIG

Official implementation of Conflict-Free Inverse Gradients Method
https://tum-pbs.github.io/ConFIG/
MIT License
25 stars 0 forks source link

`latest` should be `least` #3

Closed ValerianRey closed 1 month ago

ValerianRey commented 2 months ago

Hey! For the context, I'm starting to look at your code to see if a ConFIG aggregator could be added to TorchJD.

I found something that I think is a typo, but that actually appears in your public interface, so I would recommend to fix it before you have too many users (as the change won't be backward-compatible).

The use_latest_square parameter should be use_least_square as far as I understand, because it determines whether to use the torch.linalg.lstsq function. More generally, I think that the word latest is used many times instead of least.

qiauil commented 1 month ago

Hi， ValerianRey.

Thanks for your comment! You are correct! It is a typo. we will fix it!