tum-pbs / DMCF

Guaranteed Conservation of Momentum for Learning Particle-based Fluid Dynamics (NeurIPS '22)
MIT License
49 stars 10 forks source link

Question about the max density? #15

Closed chenyu-xjtu closed 7 months ago

chenyu-xjtu commented 7 months ago

Hi! I am confused with the metric "Max Density". Does the metric "Max Density" refer to the maximum density of fluid particles, or is it the relative error between the maximum density of the fluid and the maximum density of the ground truth?

In the paper, Formula (15) for "Max Density" likely denotes the latter, i.e., the relative error of maximum density, where a value closer to 0 is preferable. image

However, Table 2 in the appendix suggests that "Max Density" is the former, meaning the maximum density of fluid particles, where values closer to 1 are considered better. image

Looking forward to your early reply! Thanks!

Prantl commented 7 months ago

Hi! Yes I can see why this can be confusing. The latter is true. The values in Table 2 are not the raw error values but relative accuracy values as described in Figure 6. I.e. a value of 1 corresponds to the error of our final method, while small values represent a lower relative accuracy and thus larger error. A value of 0.5, for example, would mean half the accuracy and double the error. We chose this format to relate the error to the final method, which we felt was important in an ablation study, and to normalise the error evaluation for better visualisation in the graph. I hope that answers your question?