search

tum-pbs / PhiFlow

A differentiable PDE solving framework for machine learning
MIT License
1.43k stars 193 forks source link

Layers default argument in Built in Neural Networks [Fix] #84

Closed kbali1297 closed 1 year ago

kbali1297 commented 1 year ago

Removed layers default argument in conv_net and res_net and added default argument layers=[] in the CouplingLayer class. Added kwargs as argument in u_net, conv_net and res_net to accommodate the missing layers argument in u_net function definition analogous to layers** in conv_net and res_net function definitions.

holl- commented 1 year ago

This seems reasonable. Could you describe the new kwargs parameter in the documentation notebook? It should probably just say that this is a placeholder for arguments that are not supported by the function, such as layers.

kbali1297 commented 1 year ago

Sure, I have added the description for **kwargs in the documentation notebook.