tum-pbs / PhiFlow

A differentiable PDE solving framework for machine learning
MIT License
1.43k stars 193 forks source link

removed matplotlib function in vis animate code #85

Closed ParticularlyPythonicBS closed 1 year ago

ParticularlyPythonicBS commented 1 year ago

vis animate code uses figboxes on line 75. This was deprecated in matplotlib 3.4 and has been completely removed since.

So this running this function as shown in many tutorials will raise AttributeError: 'AxesSubplot' object has no attribute 'figbox' error to the end user.

To return the original functionality the line will need to be altering following this issue on the matplotlib repo.

holl- commented 1 year ago

Thanks! I've pushed a fix to develop. The unit tests now pass so I think it should work.