search

tum-vision / LDSO

DSO with SIM(3) pose graph optimization and loop closure
GNU General Public License v3.0
656 stars 235 forks source link

Remove unnecessary null pointer checks #51

Open elfring opened 4 years ago

elfring commented 4 years ago

Extra null pointer checks are not needed in functions like the following.

NikolausDemmel commented 4 years ago

Sure, thanks.

Given that this project is not under very active development, and IMHO it's more of a cosmetic / stylistic issue, I guess this is low priority.

Please consider providing a PR.

elfring commented 4 years ago

How do you think about to use a development tool like “clang-tidy” for corresponding source code adjustments?

NikolausDemmel commented 4 years ago

In general, a great tool. For current projects I also love clang-format.

But again, since this is not really active, I think we won't be able to invest the time to properly set up these tools for this project. Lack of proper testing makes this all the more difficult. A wider systematic reformatting or cleanup would also mean other branches are existing small extensions that we and maybe others have locally would need to be updated to be able to merge the occasional bugfix that is applied to master here in the future.

I would consider merging PRs that make isolated and very-easy-to-verify cleanups, but maybe not major refactoring across the whole code base. However, I personally think its not really worth to invest too much time here at this stage. Are you planning major development on top of the current code base? Maybe you might better off forking the project and taking over maintenance yourself there in the way you like, sorry.

elfring commented 4 years ago

I am generally checking the change acceptance in some software areas (before I might contribute further improvements).

NikolausDemmel commented 4 years ago

Ok, that is very reasonable. Sorry this project isn't more active and thus the answer is rather negative.