search

tum-vision / LDSO

DSO with SIM(3) pose graph optimization and loop closure
GNU General Public License v3.0
669 stars 236 forks source link

Improve exception safety with smart pointers #52

Open elfring opened 4 years ago

elfring commented 4 years ago

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?

NikolausDemmel commented 4 years ago

Please see my comment: https://github.com/tum-vision/LDSO/issues/51#issuecomment-602745613

In general, yes, that is great practice. For this project at this stage probably too intrusive with no real benefit considering development is not active, sorry.

t-lou commented 4 years ago

I don't mind trying to fix some and creating pull requests, would it be okay?