search

tum-vision / tum_ardrone

Repository for the tum_ardrone ROS package, implementing autonomous flight with PTAM-based visual navigation for the Parrot AR.Drone.
http://wiki.ros.org/tum_ardrone
GNU General Public License v3.0
226 stars 192 forks source link

Reviving tum_ardrone #16

Closed lesire closed 10 years ago

lesire commented 10 years ago

Message to all tum_ardrone user/dev, and specially addressed to @JakobEngel @dgitz @Lolu28 @Horizon0156 @phuicy @ffurrer @jennyhasahat

tum_ardrone looks dead when you look at the project activity (commits, pull requests, ...). However, I have just had a look at the forks, and a lot of people are forking and updating this code. Several of us have updated the package to use catkin. Some of us have made some quite specific updates: I personally tried to use actionlib in place of the script language, others implemented publication of PCL data, odometry, multiple drone version, ...

Maybe its time to converge and have a unique repo, with maybe several maintainers, and some branches on it so that the project may look alive again!

What is your opinion on that and your view of maintaining tum_ardrone? Is there somebody from tum-vision here that may transfer or add maintenance to more active devs?

ffurrer commented 10 years ago

I would be up for code reviews now and once I have a drone again, which will be quite soon, with testing and where help is needed.

lesire commented 10 years ago

ok, so you are the official maintainer of this repo? what's the strategy with this package? there is no branch in it, so is it planned to merge everything into master, or do you plan to create e.g. hydro-devel or indigo-devel branches? what about contributions?

updating the doc, and including a part about contributing via pull requests, would be a good idea

I can help if you want (e.g., having a look at all contributions in forks about catkin support, and format a unique pull request)

ffurrer commented 10 years ago

No I'm not the maintainer, would just be there to help in case there is interest in that.

JakobEngel commented 10 years ago

Yep, I am here ;) - mainly because I got an email, as you mentioned me explicitly. Unfortunately, as you noticed, I do not have the time to properly look after the project any more, which is a shame really (I'm just too busy with other stuff).

Of course I'd very much appreciate it if you, or someone else can look after it & give you my support / transfer maintenance rights etc. Starting this thread seems like a good start, considering that, as you said, many forks seem to do the same modifications, in particular catkin-compatibility.

lesire commented 10 years ago

I am of course ready to help, and I can for instance review pull requests or try to organise a bit the repo. My only limitation is that I am not a ROS addict, and I am only using ROS as part of another ecosystem. Hence, I won't be able to track all ROS modifications, or to test the repo for, e.g., indigo until indigo is released on my system. So I think a good idea could be to have a team of maintainer, among who an active ROS user.

Anyway, I can already propose the following improvements/roadmap:

  1. create a hydro-devel branch in which we have to merge all commits/forks that are adding catkin support and fixing issues
  2. encourage people to contribute by making pull requests instead of keeping their own fork
  3. having a core maintainer team to decide on major improvements that will be done on alternative branches on the main repo
rohanbhargava11 commented 10 years ago

I have been working on ROS for past three years. My lab recently bought an ardrone and we have been testing tum_ardrone on it for past two months. I am more than happy to help to revive the tum_ardrone package.

KarolHausman commented 10 years ago

Hi everyone,

I've been working with the tum_ardrone package for awhile and I have experience with ROS too. I would be happy to help.

I think the idea of creating another catkin branch is great. I have at least 2 forks where I contributed with different things so I could create a pull request with that. However, I am quite busy these days so it might take awhile...

Cheers, Karol On Apr 15, 2014 8:50 AM, "Rohan Bhargava" notifications@github.com wrote:

I am willing to help. I have been working on ROS for past three years. My lab recently bought an ardrone and we have been testing tum_ardrone on it for past two months. I am ready to help to revive the tum_ardrone package.

— Reply to this email directly or view it on GitHubhttps://github.com/tum-vision/tum_ardrone/issues/16#issuecomment-40498651 .

lesire commented 10 years ago

@JakobEngel if you can add, at least me, to the repo maintainers, I can start by reviewing pull request #15 (which has catkin support) and create a hydro-devel branch for that

JakobEngel commented 10 years ago

sounds good! I have given you and Karol admin rights to the repository, and @rohanbhargava11 and @ffurrer write access. let me know if there is anything else :) Cheers, Jakob

KarolHausman commented 10 years ago

Thanks Jakob! On Apr 16, 2014 8:09 AM, "JakobEngel" notifications@github.com wrote:

sounds good! I have given you and Karol admin rights to the repository, and @rohanbhargava11 https://github.com/rohanbhargava11 and @ffurrerhttps://github.com/ffurrerwrite access. let me know if there is anything else :) Cheers, Jakob

— Reply to this email directly or view it on GitHubhttps://github.com/tum-vision/tum_ardrone/issues/16#issuecomment-40610392 .

dgitz commented 10 years ago

My lab is actively working on extending the capabilities of the slam package as well. We are primarily using fuerte so it would be nice to not lose the rosbuild functionality.

David Gitz UIC EE Masters Student 618-560-4335 (c)

On Wed, Apr 16, 2014 at 10:16 AM, Karol Hausman notifications@github.comwrote:

Thanks Jakob! On Apr 16, 2014 8:09 AM, "JakobEngel" notifications@github.com wrote:

sounds good! I have given you and Karol admin rights to the repository, and @rohanbhargava11 https://github.com/rohanbhargava11 and @ffurrer< https://github.com/ffurrer>write access. let me know if there is anything else :) Cheers, Jakob

— Reply to this email directly or view it on GitHub< https://github.com/tum-vision/tum_ardrone/issues/16#issuecomment-40610392>

.

— Reply to this email directly or view it on GitHubhttps://github.com/tum-vision/tum_ardrone/issues/16#issuecomment-40611425 .

lesire commented 10 years ago

ok, so now I have rights, so tonight I will:

afterwards (once catkin would be supported on groovy-devel), I propose to create a new 'hydro-devel' branch from it and try to merge other contributions

lesire commented 10 years ago

@JakobEngel you gave me rights on tum-vision/ardrone_autonomy, but not on tum-vision/tum_ardrone. Could you please update the rights ot the tum_ardrone admins?

JakobEngel commented 10 years ago

oops, sorry - done.