Closed arturtoshev closed 3 months ago
Attention: Patch coverage is 91.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 82.1%. Comparing base (
6428cff
) to head (9f1f397
).
Files | Patch % | Lines |
---|---|---|
lagrangebench/data/data.py | 50.0% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does not disrupt anything, so fine by me. In the end you didn't change the logic of the dataset class. Should we speity in the docstring to the dataset that download starts if the directory does not exist?
dataset_path: Path to the dataset. Download will start automatically if dataset_path does not exist.
there you go: 9f1f397
dataset
a group of config parameters