search

tumanob / wp-vr-view

Wordpress plugin to add photosphere images and 360 video to wordpress posts, pages etc
GNU General Public License v3.0
20 stars 9 forks source link

Wrapping iframe into a customisable div #2

Closed tbouron closed 6 years ago

tbouron commented 7 years ago

Hi there.

As per as the title, this wraps the image and video <iframe> into a <div> with the class wp-vr-view. It does not affect the css shipped with the plugin, however a user can now customise the display of the iframe (it was not particularly easy to target the <iframe> in CSS only)

I didn't put the class on the <iframe> directly because this HTML tag is a bit special: for instance, you cannot use pseudo CSS selectors :before or :after, hence the wrapping <div>

tbouron commented 7 years ago

Brilliant! Do you have an ETA on the next release that will include this @tumanob ?

tumanob commented 7 years ago

I am working over some more changes for the plugin but I plan to release it with in two weeks.

tbouron commented 7 years ago

Ok cool. I was just wondering as you didn't merge my PR yet

Thanks @tumanob

tbouron commented 7 years ago

@tumanob Any news of a new version including this?