search

tumashu / ivy-posframe

ivy-posframe is a ivy extension, which let ivy use posframe to show its candidate menu, ivy-posframe is a **GNU ELPA** package.
414 stars 26 forks source link

Fix to properly exit the action list #103 #104

Closed tttuuu888 closed 3 years ago

tttuuu888 commented 3 years ago

This is to solve issue #103 but not whole issues but the second part of my summary. This is almost identical to the pull request I made on ivy(swiper) repository. (https://github.com/abo-abo/swiper/pull/2757) The pull request on ivy isn't accepted yet but I believe this will safely solve a problem from issue #103.

Details of the pull requests are as below:

  1. Fix that pressing ESC is showing "^[ is not bound" issue.
  2. Fix that pressing C-g is showing "^[ is not bound" issue.
  3. Add support M-o key bind to properly exit the action list.
  4. Make unbound key message more intuitive. (ex. "^A is not bound" -> "C-a is not bound")

Thanks.

tumashu commented 3 years ago

do you have sign gpl paper?

tttuuu888 commented 3 years ago

@tumashu Yes I have.

tumashu commented 3 years ago

merged, thanks