search

tumashu / ivy-posframe

ivy-posframe is a ivy extension, which let ivy use posframe to show its candidate menu, ivy-posframe is a **GNU ELPA** package.
414 stars 26 forks source link

Moving to Elpa #95

Closed Ergus closed 4 years ago

Ergus commented 4 years ago

Hi:

In the mailing list we have been talking these days about some modernization changes in Emacs. Today ivy-posframe called out attention as it seems an interesting interface alternative to the ones available either in vanilla emacs and elpa.

Could you consider to move ivy-posframe to the official elpa to become one of the official packages? We know the process could be a bit cumbersome; but it really worth the effort and we are available to help as much as possible.

Pending from your reply, Best regards, Ergus

tumashu commented 4 years ago

wow, it may need some work, for i merge many pr, i do not know them gpl paper sign status.

tumashu commented 4 years ago

The friends in below list, do you have asigned gpl paper?

  1. @abo-abo (ok)
  2. @conao3 (ok)
  3. @tttuuu888 (ok)
  4. @CeleritasCelery (ok)
  5. @xeijin ( ) <15
    https://github.com/tumashu/ivy-posframe/commits?author=xeijin
  6. @gagbo (ok)
  7. @noctuid ( ) >15
    https://github.com/tumashu/ivy-posframe/commits?author=noctuid
  8. @ramsayleung (ok ) >15
    https://github.com/tumashu/ivy-posframe/commits?author=ramsayleung
  9. @drrlvn ( ) <15 https://github.com/tumashu/ivy-posframe/commits?author=drrlvn
conao3 commented 4 years ago

Good proposal, I have already signed gpl paper.

tttuuu888 commented 4 years ago

@tumashu Yes I have. Thank you.

gagbo commented 4 years ago

I didn't. How should I proceed ?

tumashu commented 4 years ago

@gagbo https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html#Copyright-Assignment

tumashu commented 4 years ago

Copyright assignment is a simple process. Residents of some countries can do it entirely electronically. We can help you get started, including sending you the forms you should fill, and answer any questions you may have (or point you to the people with the answers), at the emacs-devel@gnu.org mailing list.

Ergus commented 4 years ago

I didn't. How should I proceed ?

Hi:

The process takes some daysto complete, but is actually simple.

https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

Just send an email in your name to emacs-devel@gnu.org asking for a Copyright Assignment for an Elpa package. You will receive a small form asking basic data: Name, package you will contribute to, email and not much more. And then you'll receive a document you should print-sign-scan-emailback.

And that's it.

CeleritasCelery commented 4 years ago

I have signed the paper work.

Ergus commented 4 years ago

Hi, no progress on this? :( I haven't check how much everyone contributed, but remember that small contributions don't require paperwork. And there is also the possibility for them to just disclaim their contribution to this if they don't want to sign a copyright assignment; which is simpler indeed.

gagbo commented 4 years ago

I have signed a week ago, still waiting on news

tumashu commented 4 years ago

@Ergus What is the standard of "small contributions" ? code line number?

This ?

We can accept small changes (roughly, fewer than 15 lines) without an assignment. This is a cumulative limit (e.g., three separate 5 line patches) over all your contributions.
tumashu commented 4 years ago

@Ergus

  1. @ramsayleung has contributed >15 lines code, they are defcustom variables, small contributions?

    https://github.com/tumashu/ivy-posframe/commits?author=ramsayleung

  2. @noctuid ( ) has contributed > 15 lines code, many of them come from ivy.el and swiper.el. so I do not know how to deal with it.

    https://github.com/tumashu/ivy-posframe/commits?author=noctuid

ramsayleung commented 4 years ago

The friends in below list, do you have asigned gpl paper?

Hi @tumashu, I don't have asigned gpl paper for now, I am not familiar with Elpa, is it necessary to have one to move ivy-posframe to the official elpa? I just committed 24 lines code to ivy-posframe, is there something to do with me?

tumashu commented 4 years ago

@ramsayleung I am waiting @Ergus 's suggestion :-)

Ergus commented 4 years ago

@ramsayleung I am waiting @Ergus 's suggestion :-)

Hi: I replied on yesterday but somehow the message it has disappeared.

@ramsayleung The paperwork is required in any case :( but it is indeed very simple (just a couple of emails). If you don't want to do the copyright there is also a possibility to do a disclaim (which is even simpler to do); but IMO the copyright it better because enables yo continue contributing any time in the future if the package goes to elpa.

Whatever you decide it starts sending an email as explained in the links above.

Best, Ergus

ramsayleung commented 4 years ago

@ramsayleung The paperwork is required in any case :( but it is indeed very simple (just a couple of emails). If you don't want to do the copyright there is also a possibility to do a disclaim (which is even simpler to do); but IMO the copyright it better because enables yo continue contributing any time in the future if the package goes to elpa.

@Ergus Thanks for your head's up, I know the necessity of a paperwork now. Is there any guide about how to sign a GPL paper? I have never signed a GPL paperwork before.

Ergus commented 4 years ago

https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html#Copyright-Assignment

Just write to the emacs mailing list and as for a copyright assignment for an elpa package, they will replly with the small form to fill.

tumashu commented 4 years ago

@Ergus If we can not contact with @noctuid, how we should do? elimit his commit?

Ergus commented 4 years ago

@Ergus If we can not contact with @noctuid, how we should do? elimit his commit?

Hi:

You must ask in the mailing list how to proceed; maybe they'll provide an alternative. Please email yourself to the mailing list as the project head: emacs-devel@gnu.org and explain the situation.

Send also the link to the project and all the basic information that could be important for them to give an accurate reply.

See you there, Ergus

tumashu commented 4 years ago

@abo-abo Is it possible to merge ivy-posframe to ivy？

noctuid commented 4 years ago

I will send an email asking about assignment. Feel free to ping me in a few days if I haven't commented here again.

ramsayleung commented 4 years ago

I have signed the paper work :)

tumashu commented 4 years ago

cool!

tumashu commented 4 years ago

@noctuid @gagbo Hi friends, gpl paper status? :-)

noctuid commented 4 years ago

I will have to find someone at my company who can sign a disclaimer that the company won't try to claim my contributions. I am looking into it.

gagbo commented 4 years ago

I received the countersigned paper earlier today, I'm done with the paperwork

tumashu commented 4 years ago

@noctuid OK

abo-abo commented 4 years ago

@abo-abo Is it possible to merge ivy-posframe to ivy？

It's possible. But why would you like to do it? I think it's better to have a separate repo and list of issues.

Ergus commented 4 years ago

Pong :-)

Hi @tumashu

You already have some repos in Elpa. So you know how to proceed. Do you need something else why did you ping in the mailing list?? @noctuid is already done with the paperwork?

tumashu commented 4 years ago

@Ergus Because the below line in README :-)

There is no approval process for GNU Elpa packages.  Still,
you must send an email to emacs-devel for several reasons:

- Notifying other developers;
- Making sure the package doesn't break FSF rules;
- Checking if the package is not reinventing the wheel;
- Ensuring that first-time developers are doing it right.

As for @noctuid's contribution, I think ok now, for the below three reasons:

  1. https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg01982.html
  2. https://lists.gnu.org/archive/html/emacs-devel/2020-09/msg02049.html
  3. I have rewrite most of his code according to newest ivy.el ivy-avy.el and swiper.el, should < 15 lines now.