tumashu / org2web

A static site generator based on org-mode
http://tumashu.github.io/org2web
89 stars 10 forks source link

Command to launch org2web-uploader-script in org2web-generate-and-run-uploader does not work #18

Open mbkamble opened 5 years ago

mbkamble commented 5 years ago

Hi. I am wondering why you need the single quote when formatting the string as the COMMAND argument to start-process-shell-command in the function org2web-generate-and-run-upolader() in org2web.el

(start-process-shell-command
                 "org2web-uploader-script"
                 nil
                 (format "%s -e 'bash %s'"
                         org2web-terminal-emulater
                         uploader-file))

My org2web-terminal-emulater resolves to x-terminal-emulator (I am on a Deepin Linux desktop) and the process fails to launch because it treats the string 'bash /usr/bin/x-terminal-emulator' as the executable name. Maybe it works with the other emulaters such as gnome-terminal, konsole or rxvt*. In any case, that string needs to be user configurable. Even without the single quotes, x-terminal-emulator just launches a window with the first string after the '-e' as the command (i.e. bash) and ignores the second argument. I am happy with the Deepin provided term emulator called deepin-terminal and prefer not to install gnome-terminal or rxvt just for this.

I'll send a patch/PR if I get to a generic solution. Regards, Milind

jonathanabennett commented 5 years ago

Any progress on this? Currently, I have to navigate into ~/.emacs.d/org2web/tmp/project.name, chmod org2web-uploader-script, and then run it.