search

tumashu / posframe

Pop a posframe (just a child-frame) at point, posframe is a **GNU ELPA** package!
450 stars 58 forks source link

configure posframe position during creation if position is available #124

Closed taquangtrung closed 1 year ago

taquangtrung commented 1 year ago

Hi,

I'm using Emacs for MacOS (https://emacsformacosx.com), and when running Helm posframe, Emacs always flickers when showing the posframe.

The reason is that the posframe frame is first created at location (0, 0), and it is supposed to be invisible, and will be moved to the desired position later. However, in Emacs for MacOS, somehow the posframe was visible before it is moved to the new location, which causes the flickering.

In this PR, I fixed this issue by supplying the position information (if it is available in the form of (left . top)), so that the posframe is created at the desired location when position is supplied.

Can you review this PR and merge it if possible?

Thanks!

tumashu commented 1 year ago

merged, thanks!