tumashu / posframe

Pop a posframe (just a child-frame) at point, posframe is a **GNU ELPA** package!
450 stars 58 forks source link

add posframe-poshandler-frame-top-left-or-right-other-corner #130

Closed JJPandari closed 1 year ago

JJPandari commented 1 year ago

To me it's a common need to show some docs (eldoc, lsp doc) on the other side (left or right) of frame, depending on current window's position. So I'd like to add this handler to posframe as built-in. Hope you guys agree with me on this.

Using eldoc-box I see this behavior is already there, but I didn't study how eldoc-box implement this, because I found it easy to do with existing code in posframe.

tumashu commented 1 year ago

Do you have sign GPL paper? posframe is GNU Elpa package, need do this.

JJPandari commented 1 year ago

No I haven't. Let me see how to do it.

JJPandari commented 1 year ago

https://github.com/tumashu/pyim/issues/376 看了一下没确定,是发到emacs-devel还是别的地方比较好?

tumashu commented 1 year ago

发到 emacs-devel 就可以,管理员看到后会私发一个邮件给你,按流程走就OK

tumashu commented 1 year ago

另外一个方法是把 patch 减小到15行以内,可以当作小改动而不需要签协议

JJPandari commented 1 year ago

签好了,整个流程跑完了。

tumashu commented 1 year ago

merged, thanks