search

tumashu / posframe

Pop a posframe (just a child-frame) at point, posframe is a **GNU ELPA** package!
450 stars 58 forks source link

Use of wrong default no-accept-focus frame parameter #136

Open gerd-moellmann opened 8 months ago

gerd-moellmann commented 8 months ago

The default for key parameter accept-focus of posframe--create-posframe is nil. That means any caller of that function which doesn't explicitly specify a keyword argument :accept-focus t will use a no-accept-focus t frame parameter.

This leads to warnings under macOS, for which I submitted bug 69525 to Emacs. I propose the following change:

modified   posframe.el
@@ -579,7 +579,7 @@ You can use `posframe-delete-all' to delete all posframes."
                                      override-parameters
                                      respect-header-line
                                      respect-mode-line
-                                     accept-focus)
+                                     (accept-focus t))
   "Create and return a posframe child frame.
 This posframe's buffer is BUFFER-OR-NAME.
tumashu commented 8 months ago

it has other bug, need no-accept-focus t by default.

gerd-moellmann commented 8 months ago

tumashu @.***> writes:

it has other bug, need no-accept-focus t by default.

Could you please elaborate? What bug is it? Is it something that should be fixed in Emacs?