tumashu / vertico-posframe

GNU General Public License v3.0
106 stars 16 forks source link

If my search gets really long, I can no longer see the candidates #14

Closed draxil closed 2 years ago

draxil commented 2 years ago

If my search gets too long for the posframe, the whole view aligns so I can no longer see the candidates:

image

This doesn't happen in "vanilla" vertico as it just wraps:

image

I feel like this is a recent thing, although maybe I've just started using longer paths.

tumashu commented 2 years ago

https://github.com/tumashu/vertico-posframe/commit/ef430c2a8a69939bd8b358670fe83fb3e75a4ffd

try (setq vertico-posframe-truncate-lines nil)

draxil commented 2 years ago

Magic that fixes it for me! Thanks

minad commented 2 years ago

@tumashu I don't think the addition of vertico-posframe-truncate-lines is a good idea. You usually want truncation enabled and only disable it when the input becomes too long. See https://github.com/minad/vertico/blob/a92b1e47ffe343e2c3096e2ea61af013a8a02af9/vertico.el#L558 for how Vertico itself handles this. Maybe that automatic solution could work for vertico-posframe too?

tumashu commented 2 years ago
Maybe that automatic solution could work for vertico-posframe too?

Maybe :-)