tumashu / vertico-posframe

GNU General Public License v3.0
106 stars 16 forks source link

Avoid advices #26

Closed minad closed 1 year ago

minad commented 1 year ago

In the next Vertico release you can use cl-defmethod to hook in more cleanly into Vertico. See https://github.com/minad/vertico/commit/2346498e6ae9e00947ac3ca6cad5def61df0ea24.

tumashu commented 1 year ago

If use cl-defmethod, I think vertico--resize-window should be renamed to vertico-resize-window, for it is public interface now:-)

minad commented 1 year ago

No, it will stay internal.

tumashu commented 1 year ago

:)

minad commented 1 year ago

There is no reason to make these APIs public. It is only a cleaner technique to provide extension mode implementations.

tumashu commented 1 year ago

ok, I will wait new version of vertico :-)

minad commented 1 year ago

I've released a new version. See also https://github.com/minad/vertico/issues/331 which should help you with #29.

tumashu commented 1 year ago

Fixed.