tumashu / vertico-posframe

GNU General Public License v3.0
106 stars 16 forks source link

not compatible with latest version of vertico-multiform #40

Closed orzechowskid closed 8 months ago

orzechowskid commented 8 months ago

vertico-posframe does not install when using the latest version of vertico-multiform:

Debugger entered--Lisp error: (void-variable posframe)
  byte-code("\303\10>\203\13\0\10\210\202\17\0\303\10B\20\304\11!\210\305\n\306\307#\210\310\311\312\313\314\315%\207" [vertico-multiform--display-modes posframe vertico-multiform-map vertico-posframe-mode vertico-multiform--define-display-toggle define-key [134217808] vertico-multiform-posframe cl-generic-define-method vertico--setup (:after) (&context ((vertico-posframe-mode-workable-p) (eql t))) nil #f(compiled-function () #<bytecode 0x19517399107afe8c>)] 6)
  require(vertico-posframe nil t)
  (not (require 'vertico-posframe nil t))
  (if (not (require 'vertico-posframe nil t)) (display-warning 'use-package (format "Cannot load %s" 'vertico-posframe) :error))
  (condition-case err (if (not (require 'vertico-posframe nil t)) (display-warning 'use-package (format "Cannot load %s" 'vertico-posframe) :error)) ((debug error) (funcall use-package--warning28 :catch err)))

this commit removes the vertico-multiform--define-display-toggle macro and causes the above error.

failable commented 8 months ago

Same issue

tumashu commented 8 months ago

please try agian

agzam commented 8 months ago

27d3939 fix appears to be working. Thank you @tumashu

orzechowskid commented 8 months ago

yes, thank you!