search

tumblfeed / nzbunity

Adds the ability to send and control Usenet NZB files from various sites to SABnzbd+ or NZBGet download clients.
Mozilla Public License 2.0
46 stars 8 forks source link

nzbindex - download selected #27

Open CreationsPD opened 5 years ago

CreationsPD commented 5 years ago

Initial Issue: nzbindex(.nl/.com) on my searches has the par's separate from the main content.

Main Problem: nzbunity "Download Selected" doesn't do anything Site's Native "Download Selected" doesn't get caught by nzbunity and a new nzb file is in my local download directory.

My Current Workaround: In this case, I use the individual nzbunity download for both but nzbget considers the pars a dupe and moves it directly to history. At this point I have to do the big pause before the main download is done, tell the dupe to download again, merge both, then undo the big pause.

clutterskull commented 5 years ago

That sounds obnoxious. I'll look into it.

clutterskull commented 5 years ago

When I fist looked at the "Download Selected" not doing anything, at least in my case, uBlock Origin was blocking all requests to nzbindex, and once I turned it off for that site the button started working again. Not sure why that's been flagged, but that could be a cause, even though that's not your main problem.

For the rest of your question, NZBUnity kind of does a workaround on nzbindex.nl since, as you say, the pars/articles are all listed separately. The site puts a link to their auto-generated nzb in the "download" link on each search entry. NZBUnity only ever looks at this link, and in the case of the "Download Selected" button, it simply attempts to download the full nzb from that link for each item you have selected. It makes no attempt to distinguish parts of files or pars. So, at least in that case, NZBUnity's "Download Selected" works much differently than the site's native "Download Selected".

I don't personally use nzbindex, but I know a lot of people who use the addon do, so is there wording I could use for that button or some other way I could improve the addon to better make use of the site?

CreationsPD commented 5 years ago

Thank you for your quick reply, I figured out part of it with your response. I did try with ublock disabled without luck, but that was on the nzbindex .com & beta.nzbindex .com site. ublock disabled does fix the nzbunity "download selected" on the nzbindex .nl domain (This would also explain why sometimes the individual nzbunity icons aren't there)

As you said, when the nzbunity "download selected" is working, nzbget is still treating them as separate records (not merged). But not the same as two individual initiated records(pars are normally considered dupe). So now, the pars fail while the other continues without pars.

The native "Download Selected" creates the nzb file but downloads it into the browsers download directory. If I import this into nzbget, it works. To my understanding nzbunity should be intercepting this download?

clutterskull commented 5 years ago

For any file you select and then use the NZBUnity "Download Selected" button, it's functionally the same as just going down the list and clicking the individual NZBUnity download link on each file (ie, it sends each one as a separate NZB file based on the native "download" link, as in this image). So, if you have multiple entries selected that point to the same NZB, that NZB will be added (as a duplicate).

So it really does work differently from the native download selected button and I probably shouldn't put them together like that. There's no other good way I can think of for NZBUnity to generate a single nzb from multiple entries.

Intercepts are disabled by default for sites that have a site profile, so I could either allow intercepts or try to improve the behavior for the site in general. I'll do some testing when I have some time this week to see if intercepts will behave as you want...

But...

The download intercept relies on the webRequest API, which for security reasons does not allow the addon to have access to the file contents. The only thing you can do is look at the headers and have the option to cancel the request. This means that any nzb being intercepted must have a discrete url that can be sent to SAB/NZBGet. If the nzb file is generated by the server and does not have a url of its own (as is the case here, I think), NZBUnity won't be able to intercept it.

So I don't have high hopes, but I'll give it a shot and report back. If it does work, I will likely just remove the NZBUnity Download Selected button altogether since it doesn't really behave as expected.