search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

format provisioning errors less shittily #405

Closed byxorna closed 8 years ago

byxorna commented 8 years ago

Provisioning errors are hard to read right now. Change that to format preformatted code with like... <pre><code>...</code></pre>. @Primer42 @defect @schallert @roymarantz @maddalab

william-richard commented 8 years ago

LGTM

roymarantz commented 8 years ago

:+1: for the code, but does the "caller" have any trouble with this? it is likely to change the "shape" of the displayed message. e.g if the message used to be displayed as a single line and the formating shapes it into multi-line...

byxorna commented 8 years ago

@roymarantz this is web view only. "clients" are humans clicking buttons. This does not impact responses given over API at all

roymarantz commented 8 years ago

that is what I was hoping for. thaks

byxorna commented 8 years ago

@Primer42 merge?