fix timeout deprecation warning in collins client request

tumblr / collins

groovy kind of love

tumblr.github.com/collins

Apache License 2.0

571 stars 99 forks source link

fix timeout deprecation warning in collins client request #406

Closed byxorna closed 8 years ago

byxorna commented 8 years ago

/Users/gabe/code/collins/support/ruby/collins-client/lib/collins/api/util/requests.rb:82:inhttp_call': Object#timeout is deprecated, use Timeout.timeout instead.`

This fixes that.

byxorna commented 8 years ago

@Primer42 @maddalab @Primer42 @schallert @roymarantz

william-richard commented 8 years ago

LGTM - should this also be a minor version bump?

byxorna commented 8 years ago

Up to you @Primer42. I was going to leave it to those who can actually release the gem to make the decision (and commit) to bump the release when appropriate, as I cannot anymore :(

william-richard commented 8 years ago

@byxorna yeah if you do a version bump in this PR, once it's merged I'll make sure the new gem gets deployed to public rubygems.

byxorna commented 8 years ago

@Primer42 done.

roymarantz commented 8 years ago

:+1: for the code and version bump too.