search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

External mysql db support #470

Closed schmitmd closed 3 years ago

discordianfish commented 8 years ago

Hi @schmitmd,

can you provide some more context for this PR? It looks like you changed the config and init script so it works for you, but it probably breaks the setup for someone else.

schmitmd commented 7 years ago

The intent behind this was to add support for configuring an external MySQL database server for Collins as opposed to assuming that Collins host is also the database host.

Which part of my code would break things for someone else?

discordianfish commented 7 years ago

@schmitmd You're right, it looks like this wouldn't change the existing behavior. LGTM.

@tumblr/collins Ping? Does this mention actually works?

schmitmd commented 7 years ago

@tumblr/collins Ping again? It looks like an issue with an API hit getting the wrong response. Maybe a retry will fix it...

byxorna commented 7 years ago

@schmitmd can you merge master in and push again. Lots of fixes have been applied to the unit testing infra since you opened this diff; the unit tests were pretty flaky before

schmitmd commented 7 years ago

Builds are still failing but that's Solr indices-related.

byxorna commented 7 years ago

@schmitmd its passing now :) @defect any reservations about this landing?

schmitmd commented 7 years ago

@defect Any update?

schmitmd commented 5 years ago

I got one approval, but it looks like this PR got lost in the shuffle. Been quite a while. Anyone willing to merge it in?

yahoocla commented 5 years ago

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

schmitmd commented 5 years ago

CLA signed.

defect commented 5 years ago

Hey @schmitmd! Very sorry for the delay. I'm cutting a ticket for myself in our internal task tracking system to take a look at this before the end of the week.

schmitmd commented 4 years ago

End of the week was some weeks ago. You can just close this if it's not going to happen. No worries.

schmitmd commented 3 years ago

Giving up.