tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

collins-shell: shows memory for empty slots #481

Open discordianfish opened 7 years ago

discordianfish commented 7 years ago

Hi,

I have a high memory system here. Collins API properly shows the slots:

Memory
Total Memory    192.00 GB
Total Memory Banks  16
Used Memory Banks   12
Unused Memory Banks 4

But collins-shell shows 15 slots with 16 GB mem modules each:

+--------------------+-------------------+--------------------+---------------------+----------------------------+----------------------------+
|                                                               Physical Memory                                                               |
+--------------------+-------------------+--------------------+---------------------+----------------------------+----------------------------+
| BANK               |                  SIZE                  | SIZE_HUMAN          |                       DESCRIPTION                       |
+--------------------+-------------------+--------------------+---------------------+----------------------------+----------------------------+
| 0                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 1                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 2                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 4                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 5                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 6                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 8                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 9                  |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 10                 |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 12                 |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 13                 |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
| 14                 |              17179869184               | 16.00 GB            | DIMM DDR3 1600 MHz (0.6 ns) - Samsung M393B2G70BH0-CK0  |
+--------------------+-------------------+--------------------+---------------------+----------------------------+----------------------------+
| TOTAL SIZE (Bytes) | 206158430208                                                                                                           |
| TOTAL SIZE (Human) | 192.00 GB                                                                                                              |
+--------------------+-------------------+--------------------+---------------------+----------------------------+----------------------------+

Since this fortunately isn't scala, I can have a look at it later/tomorrow. But let me know if someone has a clue what is going on already.

byxorna commented 7 years ago

@discordianfish collins-shell is... lets say "deprecated". A subset of functionality is implemented in collins-cli, but I doubt anyone has work in flight to improve collins-shell. Feel free to take a stab at it though!

discordianfish commented 7 years ago

@byxorna Oh, I didn't know about collins-cli. That looks indeed better.. What about deprecating collins-shell for real? Right now it's a bit confusing.