tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

Trying to revive the tests #491

Closed discordianfish closed 7 years ago

discordianfish commented 7 years ago

Closes #483

byxorna commented 7 years ago

👍

discordianfish commented 7 years ago

I think this is a good start. This is still failing though:

RUN_RUBY=true RUN_SCALA=false GEM_NAME=collins-state

Could use some help fixing this. Did it ever worked? If so, I can try git-bisect'ing to found what broke it.

discordianfish commented 7 years ago

@Primer42 can we get this merged? Or even better, somehow figure out how to get those things merged quicker in the future?

william-richard commented 7 years ago

LGTM

discordianfish commented 7 years ago

@Primer42 Then go merge it! :) Is there even another maintainer active?