Skip UID verification when ipmi config is missing

[discordianfish]

This will make collins' intake process skip UID based identification when IPMI data is missing.

Let me know if you need this configurable.

[roymarantz]

Shouldn't there be a config "feature" test enabling this change in behavior? Ideally there would be unit tests too.

[discordianfish]

@roymarantz 'config "feature" test'? You mean adding some flag to app/collins/intake/IntakeConfig.scala like strict_validation:

• default: true, current behaviour
• false, skip validation steps for which config is missing (like UID for ipmi but later maybe chassis tag if that's missing)

Tests would be ideally but I'm not very familiar with scala and there are no existing tests for the intake stuff I could extend easily. If you can point me in the right direction, I can look into this though.

[roymarantz]

By feature I mean something like https://tumblr.github.io/collins/configuration.html#features and a simple example of its use can be found in app/collins/util/StateMachines.scala just look for Feature. I can't find an instance of a similar kind of test 😞 Is there an advantage to adding such a feature test in app/collins/intake/IntakeConfig.scala instead of where your code change is?

[discordianfish]

Ah, i see. Yes such feature works for me. Would call it sloppyIntake?

[roymarantz]

The name doesn't matter to much, but I'd favor something more descriptive like optionalIpmiIntake

[discordianfish]

@roymarantz Like this?

I also want to add another feature to allow skipping chassis verification as well, so might want to wait before merging this.

[roymarantz]

this looks fine with me 👍 I'd suggest adding the other feature in another PR unless you believe it is tightly linked to this one.

[discordianfish]

Fine with me. Then this is ready to get merged!

[discordianfish]

@Primer42 Ping?