search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

Add checkbox to redirect New assets to intake #495

Closed discordianfish closed 4 years ago

discordianfish commented 7 years ago

This adds a "Intake Redirect" checkbox on the index page. When checked and the search returns a single asset with status New, the browser get redirected to the intake process.

This replaces the old behavior where a search for only the tag always redirects to intake process if the asset is New.

-- Closes #454 Related: #484

/cc @byxorna @Primer42 Would that work for you? This would mean a minor change in your workflow: Instead if just scanning the tag to get to the intake process, you would initially set the checkbox once. If you just click return, the checkbox should stay checked. If you reload, it will get unchecked. But I can look into storing the checkbox state in the browser somehow if you think this is needed. See also discussion in #454

byxorna commented 7 years ago

This LGTM, awesome!

roymarantz commented 7 years ago

Instead of hardcoding the default value, perhaps get it from the configuration? That way the default could be set for the common workflow and the check box would just override it. I'm OK with this just coming from the config file instead of the checkbox too.

discordianfish commented 7 years ago

@roymarantz Which default value? Whether it's checked or not? I don't really care much about whether to use a checkbox or config. @byxorna / @Primer42: Thoughts?

roymarantz commented 7 years ago

yes whether it is checked or not.

discordianfish commented 7 years ago

@roymarantz Like this?

discordianfish commented 7 years ago

@roymarantz [x] done

byxorna commented 7 years ago

@discordianfish could you document this behavior in gh-pages branch? It appears there is no succinct description of the intake process at all in our docs (that i could find), so making a section in https://tumblr.github.io/collins/concepts.html would be fantastic to describe the normal flow, and how this checkbox impacts behavior.

@roymarantz can you re-review and remove your blocking review if all looks good?

discordianfish commented 7 years ago

Sorry but I won't have time for this anytime soon. Maybe @davidbirdsong wants to pick that up.