search

tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

Allow skipping chassis tag verification #496

Closed discordianfish closed 4 years ago

discordianfish commented 7 years ago

With the feature intakeChassisTagOptional enabled, collins will skip the chassis tag verification in the intake process if the chassis tag isn't set. It will allow adding the asset tag in the final intake step.

This is based on top of #492

byxorna commented 7 years ago

Eyeballing it lgtm, but i havent tested all the different configuration modes.

discordianfish commented 7 years ago

@byxorna Best would be to add some tests.. but since there are none for the intake process so far and I'm not very experienced with scala I'd need some help with that.

byxorna commented 7 years ago

@discordianfish the testing framework is kind of complicated, so I dont have much guidance here. @Primer42 ?

william-richard commented 7 years ago

Yeah, similar review to @byxorna - code looks good, but I haven't tested it thoroughly. There aren't any tests around intake, and I think it's out of scope to ask you to write a big part of the test framework as part of this PR.

discordianfish commented 7 years ago

Ok, then let's test this manually. I've tried it locally and deployed it to our systems. So far works as expected but our setup is tiny and the intake process not yet much used.

discordianfish commented 4 years ago

Looks like this project is dead outside tumblr at least, so closing this.