tumblr / collins

groovy kind of love
tumblr.github.com/collins
Apache License 2.0
571 stars 99 forks source link

travis-ci ruby tests broken RUN_RUBY #510

Closed roymarantz closed 7 years ago

roymarantz commented 7 years ago

the travis-ci RUB_RUBY tests are failing most probably because gemspec files want spec 2.99 but that is not compatible with rake newer than 10.x and since rake's version isn't specified 12.x is installed.

Fix, either upgrade to spec 3.x or limit rake to 10.x

byxorna commented 7 years ago

This suggested fix isnt the full solution; after sorting out rake version, there are failed tests for collins-state like:

1) Collins::DecommissionWorkflow predicate methods true when specified and same
     Failure/Error: p.start?(tag).should be true
     WebMock::NetConnectNotAllowedError:
       Real HTTP connections are disabled. Unregistered request: GET http://localhost:2037/api/asset/sl-129278 with headers {'Authorization'=>'Basic dGVzdGVyOnRlc3RwYXNz'}

       You can stub this request with the following snippet:

       stub_request(:get, "http://localhost:2037/api/asset/sl-129278").
         with(:headers => {'Authorization'=>'Basic dGVzdGVyOnRlc3RwYXNz'}).
         to_return(:status => 200, :body => "", :headers => {})

       registered request stubs:

       stub_request(:get, "http://tester:testpass@localhost:2037/api/asset/sl-129278")