Closed byxorna closed 7 years ago
This is awesome and always bugged me since I have some assets with this showing up 3 times right now.
@roymarantz ack! ive rebased and squashed down. Unfortunately this is very much a view issue, for which we dont have a framework for testing. I would be hesitant to take on adding a whole approach to validating views in this diff, as it seems like a massive amount of work at first blush
good enough. thanks
Hot 🔥 LGTM
This fixes a bug where the BASE_SERIAL attribute isnt correctly filtered when reconstructing base LSHW attributes for display. This caused the
base_serial
attribute to appear multiple times (one for each time it was inducted!), even though this attribute shouldn't have been displayed here at all (it should show up on the LSHW show page, not generic attributes).Ive also spiced up the asset overview page with some tooltips when the Label for an attribute doesnt match the Name, to make it easier to understand where the attribute comes from. Additionally, I've added some docs links to describe the classification, type, status, etc of an asset.
Fixes #477 cc @roymarantz @defect @qx-xp @michaeljs1990 @gtorre