Closed michaeljs1990 closed 7 years ago
cc @byxorna @defect @roymarantz
I like it, 👍
@roymarantz @defect @komapa @ssalevan @maddalab what do you think? I like it as well...
How will it look at 16x16 though?
so 16x16 not great i think at the 32x32 level it starts to look like something though.
I like it! I'm going to try spinning a collins container up with that as a favicon later to see what it looks like in the toolbar, but i'm sure it'll be a lot better than the default chrome or play one :)
We'll also need to check with legal on our side if there are any extra steps for contributions that aren't strictly code. I'll shoot them an email and let you guys know.
https://www.dropbox.com/s/lasukeqmgalzobb/Screenshot%202017-05-23%2008.57.07.png?dl=0
Looks OK at 16x16 to me in the Chrome tabs bar. Not great, but mostly due to me being lazy and not making the white background transparent :)
Do we need 16x16 though? Shouldn't most semi-recent versions of the most common browsers support at least 64x64?
Tbh all favicons look a bit bootleg, so if it doesn't look stellar I'm not too worried. Transparency would be nice though. Should this change include a bit of branding on the navbar and documentation as well?
Also, can you include screenshots of the tab with common browsers?
This looks great. @defect It looks like you used a favicon and didn't also implement the higher resolution options available these days -- it might make the icon look much better: https://davidwalsh.name/retina-favicons
@grahamc Hehe yeah. I went early 2000s style for a worst-case :) Still looked pretty decent i thought! Especially if we can get some transparency in there.
Once we get legal sign-off I'll ask the frontend folks for advice, unless people here all ready know best practices for favicons.
Good news! We got the sign-off from legal. Sorry for the super long delay. Unless someone gets to it before me, I'll work on getting a PR out later this week. It's been a while since I did any frontend work though :)
Merged in #563. Thanks @michaeljs1990!
Can we get a super sweet logo for collins? This will improve the user experience for me significantly since i sometimes find it hard to find collins when i have 20 tabs open and it has no favicon.
This is kinda random but I have this logo I had made for another project that I never launched. It's a sweet chihuahua that in no way relates to the name of this project except that I think we can all imagine it's name might be collins.